Skip to content

[sig-windows] Enable GMSA tests for Hyper-V serial-slow job#36624

Open
rzlink wants to merge 1 commit intokubernetes:masterfrom
rzlink:add-gmsa-to-hyperv-serial-slow
Open

[sig-windows] Enable GMSA tests for Hyper-V serial-slow job#36624
rzlink wants to merge 1 commit intokubernetes:masterfrom
rzlink:add-gmsa-to-hyperv-serial-slow

Conversation

@rzlink
Copy link
Copy Markdown
Contributor

@rzlink rzlink commented Mar 10, 2026

Summary

Add preset-capz-gmsa-setup label to ci-kubernetes-e2e-capz-master-windows-hyperv-serial-slow to enable GMSA domain controller provisioning, matching the process-isolated serial-slow job (ci-kubernetes-e2e-capz-master-windows-serial-slow).

Changes

1 line added: preset-capz-gmsa-setup: "true"

Context

The Hyper-V serial-slow job added in #36609 was missing the GMSA preset, causing 2 test cases to be skipped:

  • [sig-windows] [Feature:Windows] GMSA Full [Serial] [Slow] GMSA support can read and write file to remote SMB folder
  • [sig-windows] [Feature:Windows] GMSA Full [Serial] [Slow] GMSA support works end to end

GMSA (Group Managed Service Account) is an AD credential mechanism independent of container isolation mode, so it should be tested with Hyper-V isolation as well.

@rzlink
[sig-windows] Enable GMSA tests for Hyper-V serial-slow job
87e82d3 
Add preset-capz-gmsa-setup label to ci-kubernetes-e2e-capz-master-windows-hyperv-serial-slow
to enable GMSA domain controller provisioning, matching the process-isolated
serial-slow job (ci-kubernetes-e2e-capz-master-windows-serial-slow).

This enables 2 missing GMSA test cases:
- GMSA support can read and write file to remote SMB folder
- GMSA support works end to end
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2026
@k8s-ci-robot k8s-ci-robot requested a review from AnishShah March 10, 2026 17:57
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 10, 2026

Hi @rzlink. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested a review from marosset March 10, 2026 17:57
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 10, 2026
@zylxjtu
Copy link
Copy Markdown
Contributor

zylxjtu commented Mar 10, 2026

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 10, 2026

@msft-linliu: changing LGTM is restricted to collaborators

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: msft-linliu, rzlink, zylxjtu
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnishShah AnishShah Awaiting requested review from AnishShah

@marosset marosset Awaiting requested review from marosset

1 more reviewer

@msft-linliu msft-linliu msft-linliu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zylxjtu zylxjtu

Labels

area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rzlink @k8s-ci-robot @zylxjtu @msft-linliu